refactor(acp): sever nori-acp → codex-core (slice E)#526
Open
CSRessel wants to merge 2 commits into
Open
Conversation
Move the harness-domain helpers nori-acp consumed from core into nori-acp itself: user_notification, custom_prompts (dead default_prompts_dir dropped), parse_command + shell/bash/powershell, compact constants (+ templates), and create_patch_with_context (new patch.rs, out of util.rs). Hoist McpServerConfig/McpServerTransportConfig into codex_protocol::config_types; core keeps an intra-crate re-export shim. nori-acp's Cargo.toml no longer lists codex-core; cargo tree confirms the edge is gone. tui/cli reach the moved helpers via nori_acp::. Slice E of docs/specs/crate-layering.md §6.
…nment) 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slice E of
docs/specs/crate-layering.md§6 (stacked on #524). nori-acp no longer depends on codex-core —cargo tree -p nori-acp -i codex-corefinds no path.Moves (git renames, harness-domain code into the harness crate):
user_notification,custom_prompts,parse_command/+shell/bash/powershell,compactconstants (+templates/compact/), andcreate_patch_with_context(split out of core'sutil.rsintoacp/src/patch.rs, with its test) →nori-acpMcpServerConfig/McpServerTransportConfig→codex_protocol::config_types(their consumers span acp/tui/core; protocol is the neutral home). Core keeps an intra-crate re-export shim until slice F.default_prompts_dir(zero callers; itsCODEX_HOMEsemantics don't map post-move)tui/clireach the moved helpers vianori_acp::;core_test_supportnow usesnori_acp::shell(test-only crate reaching up — no production-layer inversion)notify-rust/tree-sitter/tree-sitter-bash/shlex/regexrehomed with their code (existing workspace deps, nothing new)Includes a noridocs refresh (core/acp/protocol/tui/root/execpolicy/login docs.md) documenting the new boundaries.
Validation
cargo testgreen except onecloud_modee2e flake under full-parallel load — 10/10 green in isolation, and the dedicated e2e step (AGENTS.md protocol) reports 23 suites okjust fmt/just fix -p nori-acpclean