refactor(tui): remove the nori-config cargo feature (slice C)#523
Open
CSRessel wants to merge 1 commit into
Open
refactor(tui): remove the nori-config cargo feature (slice C)#523CSRessel wants to merge 1 commit into
CSRessel wants to merge 1 commit into
Conversation
The feature was default-on and the shipped binary's only config path; the not(nori-config) branches were a dead legacy codex-config fallback. Config source is now unconditional (~/.nori/cli/config.toml via nori-acp), removing a compile-time API-boundary switch. Slice C of docs/specs/crate-layering.md §6.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slice C of
docs/specs/crate-layering.md§6 (stacked on #522). +5/−139.The
nori-configfeature was default-on and is the shipped binary's only config path; thenot(nori-config)branches were the dead legacy codex-config fallback. This removes the feature entirely:not()blocks deleted (legacy~/.codexconfig path, feature-gated/settings–/browsestubs)#[cfg(feature = "nori-config")]gates unwrapped to unconditional codetui/Cargo.toml(default = ["login"]now).nori-config.jsonreferences untouched (different subsystem — skillsets file)No consumer builds
nori-tuiwith--no-default-features(checked cli, justfiles, workflows).Validation
cargo check --workspace --all-targetsclean on first passcargo test -p nori-tui: 1,347 passed, zero snapshot changes (unwrap was behavior-neutral)cargo test -p tui-pty-e2e: 29 passedjust fmt/just fix -p nori-tuiclean🤖 Generated with Nori
Co-Authored-By: Nori contact@tilework.tech