Code sanitising: type checks #5209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
TODO: |
Merge branch 'main' into type_checks # Conflicts: # DESCRIPTION # R/geom-.R
Collaborator
Author
|
I'm putting this PR on hold pending the release of rlang 1.1.0, which is required for the imported functions. |
teunbrand
commented
Mar 8, 2023
teunbrand
commented
Mar 8, 2023
Collaborator
Author
|
I think this PR is now ready for review, but should wait with merging until rlang 1.1.0 has landed on CRAN |
thomasp85
approved these changes
Mar 14, 2023
Member
thomasp85
left a comment
There was a problem hiding this comment.
LGTM - have you checked that all checks are covered by unit tests (they should as I went through this when updating the errors before last minor release but better check again
Member
|
hopefully rlang will be released this week |
Collaborator
Author
I'll double-check this later today |
Member
|
rlang 1.1.0 is now on CRAN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #4834.
It replaces checks of the type
is.myclass(x) && length(x) == 1by {rlang} scalar checks. There was no function for scalar numeric checks, so I added one.