Skip to content

✏️ Fix typo in syntax for using the GitHub Action tag directly (instead of with Docker) in README#39

Merged
tiangolo merged 2 commits into
tiangolo:mainfrom
art049:art049-typo-fix
Nov 2, 2023
Merged

✏️ Fix typo in syntax for using the GitHub Action tag directly (instead of with Docker) in README#39
tiangolo merged 2 commits into
tiangolo:mainfrom
art049:art049-typo-fix

Conversation

@art049

@art049 art049 commented Oct 27, 2020

Copy link
Copy Markdown
Contributor

It seems that github action uses @ instead of : to define the version.

@tswfi

tswfi commented Dec 5, 2020

Copy link
Copy Markdown

Just added this action to a project and the current readme is right with ":". @ doesn't work.

@art049

art049 commented Dec 5, 2020

Copy link
Copy Markdown
Contributor Author

This fix was intended for the use of the non dockerized version.
In this case - uses: tiangolo/latest-changes:0.0.3 didn't work as "pure" github actions uses @
But it worked fine for the dockerized one like this: - uses: docker://tiangolo/latest-changes:0.0.3
Maybe github allows : as well now

@tswfi

tswfi commented Dec 5, 2020

Copy link
Copy Markdown

Oh, my bad then.

@tiangolo tiangolo changed the title Fix github actions version tag in README ✏️ Fix typo in syntax for using the GitHub Action tag directly (instead of with Docker) in README Nov 2, 2023
@tiangolo tiangolo added the docs Improvements or additions to documentation label Nov 2, 2023
@tiangolo

tiangolo commented Nov 2, 2023

Copy link
Copy Markdown
Owner

Thank you @art049! 🙇 ☕

@tiangolo tiangolo merged commit 05613c0 into tiangolo:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants