allow text blocks to handle undefined as empty strings#5
Merged
Conversation
mark-friedman
approved these changes
May 16, 2018
mark-friedman
left a comment
There was a problem hiding this comment.
The changes to the compressed files are more extensive than expected given the source changes. I assume that it's because we're using a newer version of the closure compiler. Is that right?
Collaborator
Author
|
I'm using the google's online closure service (from build.py), so I assume that its the newest closure as served from their site. |
|
Yeah, that's what I assumed.
…On Wed, May 16, 2018 at 4:24 PM, pmwthunkable ***@***.***> wrote:
I'm using the google's online closure service (from build.py), so I assume
that its the newest closure as served from their site.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABqbSscpKnfOYzSNFrF5xuDS9M2NRNgwks5tzLVBgaJpZM4UCIMX>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.