Use toast notifications for presets/samplers - #272
Merged
Merged
Conversation
Replace blocking alerts/dialogs with toast notifications across presets, quick-launch and sampler modules. Add showToast plumbing (app.js -> presets/quick-launch/sampler) and a configure hook for presets; introduce showPresetActionStatus to forward preset status messages to the toast system. Update sampler-presets and quick-launch-ui to call toasts instead of alert()/dialog(), and adjust frontend smoke test to wait for toast messages. This makes UX non-blocking and centralizes status display handling. Files: ui/js/{app,presets,quick-launch-ui,sampler-presets}.js and tests/frontend/flag_sync_smoke.cjs.
thomas9120
marked this pull request as ready for review
July 30, 2026 20:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace blocking alerts/dialogs with toast notifications across presets, quick-launch and sampler modules. Add showToast plumbing (app.js -> presets/quick-launch/sampler) and a configure hook for presets; introduce showPresetActionStatus to forward preset status messages to the toast system. Update sampler-presets and quick-launch-ui to call toasts instead of alert()/dialog(), and adjust frontend smoke test to wait for toast messages. This makes UX non-blocking and centralizes status display handling. Files: ui/js/{app,presets,quick-launch-ui,sampler-presets}.js and tests/frontend/flag_sync_smoke.cjs.