Add config_lock and fix multiple frontend issues - #270
Merged
Merged
Conversation
Introduce config_lock on ServerState and serialize load→mutate→save cycles in llama_manager, external_server, process_manager and hf_download to prevent races. Other fixes: activate_custom now claims/releases the install slot; sanitize_sse_error always logs the error; chat proxy parsing skips malformed addresses; macOS file picker returns a cancel sentinel; HF download rejects Windows device names and correctly reports 0-byte size_mb and logs partial-delete failures; lifecycle validates folder input before mkdir; startup script validates port and preserves browser errors. Tests updated/added.
Various frontend robustness and correctness fixes: guard stale responses in manager.refreshModels; log errors in waitForServerReady; include model flags and chat-template warning in flag-core; guard API key selection and server-ready text in api-tab; use shared hasLaunchModelArg in app.js; add searchable-select.destroy; avoid clobbering external-server inputs and improve disconnect badge; remove unused benchmark timer; make presets use a null-prototype map and harden import loop; protect process-lifecycle initial emit. Tests: add model-cache race test and fix remote_tunnel toggle stub.
thomas9120
marked this pull request as ready for review
July 29, 2026 23:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.