Add chat-ui tests and robustness fixes - #269
Merged
Merged
Conversation
Add a new node:vm unit-test harness for chat-ui (tests/frontend/chat_ui_unit.cjs ~420 lines) and register it in package.json and docs/tests.md. Gate test-only hooks behind window.__LLAMA_GUI_TEST_HOOKS__ and expose _test* mutators only when opted-in. Fix chat-ui issues: normalize sampler numeric inputs, omit empty/non-finite sampler values from payloads, remove dead host/port fields, persist regenerateResponse pops (delete-empty), fix read-after-abort ordering around abortActiveStream(), and add sidebar slider fallbacks. Align Repeat Penalty default in index.html and app-data.js. Also gate benchmark _testPollOutput behind the same opt-in flag. Tests and docs updated accordingly.
thomas9120
marked this pull request as ready for review
July 29, 2026 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new node:vm unit-test harness for chat-ui (tests/frontend/chat_ui_unit.cjs ~420 lines) and register it in package.json and docs/tests.md. Gate test-only hooks behind window.LLAMA_GUI_TEST_HOOKS and expose _test* mutators only when opted-in. Fix chat-ui issues: normalize sampler numeric inputs, omit empty/non-finite sampler values from payloads, remove dead host/port fields, persist regenerateResponse pops (delete-empty), fix read-after-abort ordering around abortActiveStream(), and add sidebar slider fallbacks. Align Repeat Penalty default in index.html and app-data.js. Also gate benchmark _testPollOutput behind the same opt-in flag. Tests and docs updated accordingly.