Conversation
* update rotate file definitions to match those in TAP 8 * add reference implementation * minor wording changes Signed-off-by: Marina Moore <mnm678@gmail.com>
Signed-off-by: Marina Moore <mnm678@gmail.com>
jkjell
left a comment
There was a problem hiding this comment.
Looks good to me! Just had one question.
lukpueh
left a comment
There was a problem hiding this comment.
This TAP doesn't really mention how it changes the client workflow, apart from "Clients need to check for rotations to a null key,". Is this vagueness intended? Or am I missing something?
Also, I think it uses the term "client" ambiguously.
Signed-off-by: Marina Moore <mnm678@gmail.com>
I pushed some updates that describe the client workflow. This mostly relies on TAP 8 for download of rotate files, and just adds a step of checking for a rotation to null. "client" is meant to refer to a TUF client. Is there a way I can make this more clear in the text? |
In that case, we should accept TAP 8 first before we accept TAP 20. Seems a bit fishy otherwise.
I think in the sentence "If a client wants to rotate to a different key, without having access to their currently delegated private key" client means something else. |
Signed-off-by: Marina Moore <mnm678@gmail.com>
Fair enough, I'll update the description so that this pr relies on #187
got it, fixed that one |
Depends on #187 (accept TAP 8 first)