Merged
Conversation
Signed-off-by: Marina Moore <mnm678@gmail.com>
kipz
reviewed
Feb 5, 2024
Signed-off-by: Marina Moore <mnm678@gmail.com>
joshuagl
previously approved these changes
Mar 19, 2024
Member
joshuagl
left a comment
There was a problem hiding this comment.
A couple of minor nits, but I really like making this a separate TAP. Thanks.
Signed-off-by: Marina Moore <mnm678@gmail.com>
Signed-off-by: Marina Moore <mnm678@gmail.com>
joshuagl
approved these changes
Mar 19, 2024
JustinCappos
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This TAP splits out revocation from TAP 8 to simplify both proposals as discussed in #37. This TAP relies on changes to TAP 8 proposed in #167.