verify_release: Build from git sources only#1947
Merged
jku merged 1 commit intotheupdateframework:developfrom Apr 11, 2022
Merged
verify_release: Build from git sources only#1947jku merged 1 commit intotheupdateframework:developfrom
jku merged 1 commit intotheupdateframework:developfrom
Conversation
3 tasks
Pull Request Test Coverage Report for Build 2115553619
💛 - Coveralls |
jku
commented
Apr 8, 2022
88a7fa9 to
692fa2b
Compare
Make a new (local) git clone to build from. This ensures uncommitted files do not affect the build. Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
692fa2b to
62580ab
Compare
Member
Author
|
Addressed own review comment in the force-pushes |
lukpueh
approved these changes
Apr 8, 2022
Member
lukpueh
left a comment
There was a problem hiding this comment.
Cool idea to just clone the local repo! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make a new (local) git clone to ensure uncommitted files do not affect
the build.
Signed-off-by: Jussi Kukkonen jkukkonen@vmware.com
Fixes #1942
verify_releasehas the fate of every build script in history of build scripts: it ends up handling more edge cases than originally planned 😬 We probably should be more strict about only including only very specific files in the source release manifest... but currently extra files in the source tree may end up in the source release. This should not be a problem with #1946 as it builds from a clean git clone, but it may be a problem forverify_releasethat may be run from a dirty directory.Avoid issue in
verify_releaseby building from a clean git clone. A local clone like this will have the same checked out ref as the original repo so the build result should be 100% same.