Fix Root.add_key() argument's type#1386
Conversation
|
Force-pushed after I changed my mind over the test case a bit |
jku
left a comment
There was a problem hiding this comment.
looks ok to me but could you add a regression test so root metadata with an added key serializes correctly (a test that fails with current develop and succeeds with your fix)?
I was wondering whether to add such tests case because the bug was in our test using incorrectly the class ... and in the type annotation but types in Python ... |
After the implementation of a Key class representing the public portion of a key, the method add_key() should take an argument of type Key, instead of a dictionary. Test cases are updated accordingly. Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
yeah you do have a point here -- thanks anyway. |
Fixes #1378
Description of the changes being introduced by the pull request:
Since the existence of a
Keyclass, takingKeyas an argument type seems like the logical change.The test case is updated accordingly.
Since there are no "users" of this functionality yet, I can't say if further improvements are
needed for now.
Please verify and check that the pull request fulfills the following
requirements: