Merged
Conversation
Member
|
Just two comments (unfortunately one touches a lot of lines):
|
Contributor
Author
|
Thank you for the review, @jku! Hopefully, I've managed to address your comments in the two new commits. |
jku
approved these changes
Apr 9, 2021
Member
|
Thanks, LGTM! If you want to squash these into one commit and force-push feel free to do so, otherwise I'll do a "squash and merge" (either way is fine by me but in the latter case I can only mark you as co-author as the new commit will then be mine). |
Remove use of six Signed-off-by: Velichka Atanasova <avelichka@vmware.com> Replace the use of dict.items(mydict) with mydict.items(), dict.keys(mydict) with mydict.keys() and dict.values(mydict) with mydict.values() Signed-off-by: Velichka Atanasova <avelichka@vmware.com> Replace 'import urllib' and 'import urllib.x' with 'from urllib import x' for vendor compatibility Signed-off-by: Velichka Atanasova <avelichka@vmware.com>
Contributor
Author
|
I've squashed them into one commit. Thank you, @jku. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the use of six so it is no longer a dependency and is not imported and used in any modules, tests, or scripts.
Fixes #1296
Description of the changes being introduced by the pull request:
Please verify and check that the pull request fulfills the following
requirements: