Optimize the calculation of length and hashes#1097
Optimize the calculation of length and hashes#1097joshuagl merged 1 commit intotheupdateframework:developfrom
Conversation
|
This pr uses the latest changes in securesyslib which are not yet released and that's why it fails on all python environments expect Those changes don't need additional unit tests because there are multiple tests in |
|
We'll need to update the minimum required securesystemslib in setup.py to be whichever released version includes the |
|
What happened in the appveyor builds? The tests seem to take a couple of minutes on each run but the CI build won't finish until an hour later (which I think is appveyors timeout): 5 hours for the whole thing... |
|
@MVrachev let's mark this as a draft PR until ready, please? Thanks! |
|
I converted it to a draft pr until a new release of securesyslib is released which includes the dependent functionality. |
105d8bc to
b0dda36
Compare
|
I updated this pr with the latest changes introduced on the develop branch and the necessary functions from The pr is ready for reviews. PS: Will address the comments from Joshua. |
After we had given the option to use or not hashes and length for timestamp and snapshot roles, it's good to make sure we are calculating them only when they are needed. This optimization could be important for the bigger tuf adopters. Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
b0dda36 to
ba87454
Compare
|
I rebased on the recent changes in the develop branch and the tests should no longer fail, but I don't know why tox -e py27 fails... |
|
The TimeoutError was added by me, it was merged only today (#1096 ) ... |
Fixes issue #: None
Description of the changes being introduced by the pull request:
After we had given the option to use or not hashes and length
for timestamp and snapshot roles, it's good to make sure we are
calculating them only when they are needed.
This optimization could be important for the bigger tuf adopters.
Please verify and check that the pull request fulfills the following
requirements: