This repository was archived by the owner on Jan 17, 2019. It is now read-only.
v3 topology: Add suppport for HDA links #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a new file hda.m4. This file defines macro HDA_DAI_CONFIG(idx, link_id, name) for user to define configurations for HDA Backend links. The link's data tuple will carry the HDA type info for kernel driver to check the link type. Pleae note that there are no HW configurations defined for HDA BE links because current HW configurations is more suitable for SSP BE links, but not for HDA. We'll decide what HW configurations are suitable for HDA BE links later. Signed-off-by: Mengdong Lin <[email protected]>
This patch creates sof_apl_hdmi.m4 to define topology for 3 playback pipelines, FE and BE links for HDMI/DisplayPort(DP) audio. This can be a reference to verify audio over HDMI/DP on APL platforms. The HDMI/DP frontends are named as HDMIx, to reuse the generic HDA DSP machine driver which checks the link names and will do extra initialization on HDMI/DP frontends if "HDMI" is found in the link name. This m4 does't include topology for using external HD-A analog codecs. We will create another m4 file to include both HDA display and analog audio. Signed-off-by: Mengdong Lin <[email protected]>
plbossart
reviewed
Nov 20, 2018
| sof-cht-nocodec.tplg \ | ||
| sof-cht-max98090.tplg \ | ||
| sof-apl-hdmi.tplg \ | ||
| sof-apl-nocodec.tplg \ |
Member
There was a problem hiding this comment.
I am not really hot on this one. I know Liam merged it so I guess it's a discussion for a follow-up patch...
- why does it have any references to apl?
- If the goal is to use the standard hdaudio machine driver, then why is this necessary? The analog links will only be used if the hdaudio coded is detected, so something is very odd here.
Collaborator
Author
There was a problem hiding this comment.
@plbossart We no longer need this tplg. sof-apl-hdmi.tplg was only used in early stage of HDA enabling.
Now HDA pipelines and links are added into sof-apl-pcm512x.m4, being used by QA.
Collaborator
Author
|
@lgirdwood @plbossart PR #136 is submitted to remove this sof-apl-hdmi.m4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is v3 series for PR#54.
Add a new hda.m4 that defines macro HDA_DAI_CONFIG(idx, link_id, name) for user to define configurations for HDA Backend links.
Defines a new file sof-apl-hdmi.m4 for 3 HDMI HDA links. Verified on LeafHill.
History:
v2: Use a separate file hda.m4 to define HDA stuff, instead of in existing dai.m4, as Liam suggested.
v3: Renamed sof-apl-hda.m4 to sof-apl-hdmi.m4 because it only contains 3 playback pipelines for HDMI/DP audio. Revised pipeline IDs to start from 1 and be continuous for easy maintaining.