Audio: TDFB: Optimize the circular buffer usage#7700
Audio: TDFB: Optimize the circular buffer usage#7700kv2019i merged 2 commits intothesofproject:mainfrom
Conversation
src/audio/tdfb/tdfb_hifi3.c
Outdated
There was a problem hiding this comment.
these loops could also be optimised a bit further by using some form of ffs()
|
shall we expect same code change on generic c code? c code should be always same with optimized code in case one day hifi version have bugs. |
singalsu
left a comment
There was a problem hiding this comment.
Looks good to me plus, the small saving is nice. Thank you!
|
You should add to commit message "Fixes #5273" |
kv2019i
left a comment
There was a problem hiding this comment.
@andrula-song Can you split the hifi4 change to a different commit (can be in same PR)? Otherwise looks good to go.
Optimize the tdfb_fir_sx functions by remove the duplicated usage of circular buffer. Fixes: thesofproject#5273. Signed-off-by: Andrula Song <andrula.song@intel.com>
Since there is not any intrinsic on HiFi4 can get better performance, thus share the implementation code for HiFi3 and HiFi4. Signed-off-by: Andrula Song <andrula.song@intel.com>
|
The fails in https://sof-ci.01.org/sofpr/PR7700/build10102/devicetest/index.html are worrying, but I can't figure out how it could be related to this PR. I'll proceed with merge based on earlier CI results for this PR and CI results for other PRs today. |
|
This causes DSP exception on boot and runtime pm test. |
|
This PR brings a regression thesofproject/linux#4442 |
Optimize the tdfb_fir_sx functions by remove the duplicated usage of circular buffer.
the performance I got by xt-testbench is here:
Format original(mcps) optimized(mcps) saving mcps
16/16 17.42 17.23 0.19
24/32 17.59 17.32 0.27
32/32 17.30 17.12 0.18