-
Notifications
You must be signed in to change notification settings - Fork 350
mux: implement ipc4 support #6385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| +33 −1 | config/mtl.toml | |
| +7 −3 | src/include/rimage/rimage.h | |
| +1 −0 | src/manifest.c | |
| +78 −70 | src/pkcs1_5.c |
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -34,11 +34,15 @@ | |||||||||||||||
| static const struct comp_driver comp_mux; | ||||||||||||||||
fkwasowi marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||||||||||
|
|
||||||||||||||||
| LOG_MODULE_REGISTER(muxdemux, CONFIG_SOF_LOG_LEVEL); | ||||||||||||||||
|
|
||||||||||||||||
| #if CONFIG_IPC_MAJOR_3 | ||||||||||||||||
| /* c607ff4d-9cb6-49dc-b678-7da3c63ea557 */ | ||||||||||||||||
| DECLARE_SOF_RT_UUID("mux", mux_uuid, 0xc607ff4d, 0x9cb6, 0x49dc, | ||||||||||||||||
| 0xb6, 0x78, 0x7d, 0xa3, 0xc6, 0x3e, 0xa5, 0x57); | ||||||||||||||||
|
|
||||||||||||||||
| 0xb6, 0x78, 0x7d, 0xa3, 0xc6, 0x3e, 0xa5, 0x57); | ||||||||||||||||
| #else | ||||||||||||||||
|
||||||||||||||||
| #else | |
| #elif CONFIG_IPC_MAJOR_4 | |
| ... | |
| #else | |
| #error unknown IPC version | |
| #fi |
fkwasowi marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
fkwasowi marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that verified somewhere that no OOB occurs when iterating over cd->config.streams[] using num_streams as the limit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think so, because the copy function takes into account only those streams/channels on which the mask is set, and this function is performed only for ipc4, where we have only two streams. The change has been tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still there is no clear relation between the limit of the loop and the allocation size in this function, code looks unsafe.
Uh oh!
There was an error while loading. Please reload this page.