-
Notifications
You must be signed in to change notification settings - Fork 350
Doxygen: Increase DOT_GRAPH_MAX_NODES to 120 #5978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doxygen: Increase DOT_GRAPH_MAX_NODES to 120 #5978
Conversation
This avoids a currently happening error: "error: Include graph for 'src_ipc4_int32_table.h' not generated, too many nodes (89), threshold is 50. Consider increasing DOT_GRAPH_MAX_NODES." and another warning that happened with first increase to 100: "warning: Included by graph for 'src.h' not generated, too many nodes (111), threshold is 100. Consider increasing DOT_GRAPH_MAX_NODES." Signed-off-by: Seppo Ingalsuo <[email protected]>
35bf79c to
1b2ded2
Compare
|
Not a big fan of this. Can you share a screenshot of how a graph with ~ 100 nodes looks like? I'm afraid it won't be very useful - there must be a reason why the default is 50... Another reason for this default: graph generation is by far the most time consuming part of doxygen. In fact it's often the ONLY time consuming part. The alternative is to exclude generate code Quoting a private chat from a certain @singalsu:
|
|
@marc-hb Agree, I will try the other approach. It's OK if it doesn't suppress all src.h documentation, only the big rates matrix tables. The latter warning (see commit text) was from src.h that's not computer generated. |
|
We run doxygen twice, the second time we add |
|
This escape was a bug in doxygen, it has been fixed: https://github.com/thesofproject/sof/runs/7157109995 |
|
doxygen upgrade (and fix) submitted in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Marc's patches solve this issue, so this approach is not needed. |
No, I wrote a very small script of course :-)
Unfortunately not, sorry I'm not familiar enough with Matlab. See commit message of 31b1478:
Welcome back from vacation! Can you do this? :-) |
This avoids a currently happening error:
"error: Include graph for 'src_ipc4_int32_table.h' not generated,
too many nodes (89), threshold is 50. Consider increasing
DOT_GRAPH_MAX_NODES."
Signed-off-by: Seppo Ingalsuo [email protected]