topology: tgl-max98357a-rt5682: conditionally build BT offload#4379
topology: tgl-max98357a-rt5682: conditionally build BT offload#4379yongzhi1 wants to merge 1 commit intothesofproject:mainfrom yongzhi1:xperi
Conversation
|
The above issue does not happen with either:
So looks like with both BT & EQ added, the system hits some resource limitation. |
|
@yongzhi1 can you look at sof-logger results to help root-cause the issue. I am not comfortable with such tricks unless we clarify what the problem really is - this main branch is not even using the actual pre- and post-processing. |
When "[ 8.127019] sof-audio-pci 0000:00:1f.3: error: tplg component load failed -12" happened, the dsp log stopped after printing the 4 lines: localhost ~ # sof-logger -l /lib/firmware/intel/sof/community/sof-tgl.ldc -t I also suspected something else went wrong, but so far have not found direct clue. |
There was a problem hiding this comment.
This should be BT specific rather than IIR specific check (as there are IIR uses outside of BT)
There was a problem hiding this comment.
Let me investigate a little further, there should be a more convincing cause of the failure.
There was a problem hiding this comment.
Thanks @ranj063 for sharing thesofproject/linux#3005, with that we can confirm this is indeed a resource related issue:
# code block
755913.147046] ( 18.229166) c0 ssp-dai 1.0 /drivers/intel/ssp/ssp.c:603 ssp_set_config(), ssrsa = 0x00000003, sstsa = 0x00000003
[ 755932.469962] ( 19.322916) c0 dai src/lib/dai.c:188 dai_put type 1 index 0 new sref 2
[ 755958.772044] ( 26.302082) c0 dai 2.13 src/audio/dai.c:706 dai_config() dai type = 1 index = 0 dd 0x9e142100
[ 755982.886627] ( 24.114582) c0 dai 2.13 src/audio/dai.c:736 ERROR dai_config(): No memory for dai_config.
[ 756001.115793] ( 18.229166) c0 ipc src/ipc/helper-ipc3.c:487 ERROR ipc_comp_dai_config(): comp_dai_config() failed
I agree it makes more sense to add a condition for BT instead of EQ.
|
@yongzhi1 i see similar IPC with latest build of ADL - do you see any issue latest changes ?
|
@sathyap-chrome do you have the FW log as this will show if its a memory resource error like the one reported by @yongzhi1 otherwise we should open a new issue. |
|
@lgirdwood this was seen in a valdiation machine run - wanted to understand from Yong. if we get right steps and able to repro on latest drop, will start a new issue. |
Add -DINCLUDE_BT_OFFLOAD to conditionally compile BT audio offload based on feature readiness and requirement. Signed-off-by: Yong Zhi <yong.zhi@intel.com>
|
v2 update: Create "INCLUDE_BT_OFFLOAD" option to control the inclusion of BT offload into the tplg. |
|
@yongzhi1 @sathya-nujella this may not be needed, it looks the the OOM is hitting other things as well. |
That's great to know @lgirdwood , I can check whenever the PR is ready, thanks @keyonjie |
With both INCLUDE_IIR_EQ and BT offload enabled, observe tplg load failed for:
[ 7.449626] sof-audio-pci 0000:00:1f.3: error: ipc error for 0x80010000 size 12
[ 7.449629] sof-audio-pci 0000:00:1f.3: error: failed to set DAI config for SSP0-Codec index 0
[ 7.449630] sof-audio-pci 0000:00:1f.3: error: failed to save DAI config for SSP0
[ 7.449631] sof-audio-pci 0000:00:1f.3: ASoC: physical link loading failed
[ 7.449633] sof-audio-pci 0000:00:1f.3: ASoC: topology: could not load header: -12
So conditionally compile BT as the feature is optional on tgl.
Signed-off-by: Yong Zhi yong.zhi@intel.com