audio: codec_adapter: add Waves api#3977
Conversation
|
compared to #3938 removed trail whitespace checkpatch errors |
|
SOFCI TEST |
There was a problem hiding this comment.
This should be under sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect.
There was a problem hiding this comment.
I wonder if maybe we should do a codec_adapter/codecs/ and in the kconfig just include a kconfig in the respective dir so all include info can be pushed down to individual kconfigs/cmakelists
There was a problem hiding this comment.
@cujomalainey
I think this is a good idea but I prefer it to be handled in a separate PR.
Another thing I thought about is to upstream pass-through code for Waves codec.
It will come in handy to add SOF with Waves codec to CI checks.
Where is a place to discuss if this is needed?
|
If the headers as provided "as it is" we shouldn't fix checkpatch errors. Just let them be. Otherwise, updating the headers to a new version will be painful. |
Ack, this was my opinion too - we dont want to change 3rd party headers as it will have unnecessary impact on 3rd party non upstream code - we upstream them "as-is" but with permissive license. |
|
Github Actions hang fixed by #3992, please |
|
@stolx same rebase with main branch latest is needed here too. |
There was a problem hiding this comment.
@stolx thanks for moving the header file location. It looks good now.
I have one question though. Do you really need to add the line above? I would have expected to just work. If it is really needed that fine by me. The change looks good and useful!
There was a problem hiding this comment.
agreed, if your stuff is in include you shouldnt need this
There was a problem hiding this comment.
fixed include dir to be ${CMAKE_CURRENT_LIST_DIR}/../../include/sof/audio/codec_adapter/codec/
we need it to keep MaxxEffect folder on includes path
There was a problem hiding this comment.
@stolx OK, I got your point. It works for me. Another approach would have been to use
#include "codec_adapter/codec/MaxxEffect/MaxxEffect.h"
There was a problem hiding this comment.
unfortunately, it will not work due to how MaxxEffect API is designed.
For example, take a look at MaxxEffect_Revision.h, it contains the following lines
#include "MaxxEffect/MaxxEffect.h" #include "MaxxEffect/MaxxStatus.h"
So API headers themself expect MaxxEffect folder to be on the include path.
And since API headers are provided "as-is", the only way is to add the MaxxEffect folder to includes
There was a problem hiding this comment.
@stolx thanks for your explanation! It makes sense.
add Waves MaxxEffect API definition. API is required to build SOF with Waves codec. Signed-off-by: Oleksandr Strelchenko <oleksandr.strelchenko@waves.com>
|
@lgirdwood this is read to merge from my point of view. |
|
@lgirdwood I don't think we should fix the header to pass the doxygen build just because these are 3rd party headers and we need to have them in the tree without any modification. I think the best way is to instruct doxygen to skip these files. |
This could be a valid doxygen issue that also impacts the private repo. i.e. a typo |
|
@lgirdwood you are right. we should at least figure out the cause of the errors. |
I think we should just add an exclusion case https://stackoverflow.com/questions/1354056/ignoring-files-in-project-folder-for-doxygen |
|
CI failure is unrelated kernel suspend and resume |
|
|
The doxygen build is now broken for every PR. |
add Waves MaxxEffect API definition.
API is required to build SOF with Waves codec.
Signed-off-by: Oleksandr Strelchenko oleksandr.strelchenko@waves.com