codec_adapter: fix local buffer prepare#3974
Merged
lgirdwood merged 1 commit intothesofproject:mainfrom Apr 1, 2021
cujomalainey:local_buf
Merged
codec_adapter: fix local buffer prepare#3974lgirdwood merged 1 commit intothesofproject:mainfrom cujomalainey:local_buf
lgirdwood merged 1 commit intothesofproject:mainfrom
cujomalainey:local_buf
Conversation
Contributor
Author
|
Possible fix for #3966 |
dbaluta
approved these changes
Mar 29, 2021
lgirdwood
approved these changes
Mar 29, 2021
Contributor
Author
|
Waiting for @stolx to test before putting up for full review |
mrajwa
approved these changes
Mar 29, 2021
Contributor
Author
|
Given number of LTGMs putting up for full review so once test comes back we can just merge right away if test is good |
We are only setting the parameters on the allocation of the local buffer which means if the params change on the next run it will not change and break things. Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
Contributor
Author
|
That was a rebase to fix CI, no code change |
Member
Sound like this is two bugs and this PR fixes one of them. |
Contributor
|
Yes this can only fix potential issues which may arise when we change playback params in the runtime. |
Member
|
SOFCI TEST |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are only setting the parameters on the allocation of the local buffer
which means if the params change on the next run it will not change and
break things.
Signed-off-by: Curtis Malainey cujomalainey@chromium.org