EQ: Update IPC to deliver parameters in component creation #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
singalsu
approved these changes
Sep 25, 2018
Collaborator
singalsu
left a comment
There was a problem hiding this comment.
Code looks OK to me and this has been tested to work.
Collaborator
|
@lgirdwood I will need to update FIR memory allocation and cache invalidate functions like done for IIR but better to get this PR merged first. The update will reduce the amount of malloc() - free() calls during the life cycle of FIR EQ component. Kernel side EQ IPC has been just merged so we have an IPC incompatibility until this is merged. |
lgirdwood
requested changes
Sep 25, 2018
src/include/uapi/ipc.h
Outdated
src/include/uapi/ipc.h
Outdated
Update iir and fir to get parameters at the creation time from ipc message. Parameters are originally sent from user space as part of the topology. Also update ipc.h with data members for iir and fir struct. Signed-off-by: Jaska Uimonen <[email protected]>
Author
|
@lgirdwood updated pr. you probably want the same changes to kernel sof ipc header? I'm not totally sure how these are synced, but will make the same mods there... |
Author
|
@lgirdwood, corresponding kernel pr: thesofproject/linux#161 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update iir and fir to get parameters at the creation time from ipc
message. Parameters are originally sent from user space as part
of the topology.
Also update ipc.h with data members for iir and fir struct.
Signed-off-by: Jaska Uimonen [email protected]