Tools: Fuzzer: Do not use illegal BUILD_COMMAND in CMakeLists.txt#3358
Tools: Fuzzer: Do not use illegal BUILD_COMMAND in CMakeLists.txt#3358lgirdwood merged 1 commit intothesofproject:masterfrom
Conversation
marc-hb
left a comment
There was a problem hiding this comment.
The change looks good but the commit Subject and message are really too terse and the problem statement is even incorrect: aBUILD_COMMAND is supposed to be make or ninja or similar but never cmake so the sentence "BUILD_COMMAND is not needed" is misleading.
I think I root-caused the entire issue in #2656, can you please flesh out the commit message based on that?
Can you also please add a pointer to the Duplicated & Diverged code in testbench/CMakeLists.txt ? Don't re-align the two copies yet, it's best to keep bug fix commits minimal.
|
@marc-hb Thanks! I'll improve it, I'm total noob with cmake so I didn't understand the issue enough to write a proper commit message. |
|
@singalsu any chance this will be ready today to fix build ? |
|
I'll try, let's see if it can be accepted. As far as I understand the fixed cmake code is OK and only the commit text needs to be better. |
30ef187 to
c92e59a
Compare
|
@marc-hb Would you be OK with adding you as author (if you accept this) since you did more work with this than I did? |
This patch removes the incorrect usage of BUILD_COMMAND. Having it set to "cmake" caused the cmake usage help text output to be shown only and caused the ExternalProject_Add command to believe the libsof_tplg_parser.so was built. The build for the library happened only because the next install step performed the compilation. With this fix the default build command is used instead. There's no need to define it here. Fixes thesofproject#2656 Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Marc Herbert <marc.herbert@intel.com>
c92e59a to
4efa0a3
Compare
|
Jenkins CI showing known ICL ROM error during PM. |
This patch removes the incorrect usage of BUILD_COMMAND. Having it set
to "cmake" caused the cmake usage help text output to be shown only and
caused the ExternalProject_Add command to believe the
libsof_tplg_parser.so was built. The build for the library happened only
because the next install step performed the compilation. With this fix
the default build command is used instead. There's no need to define
it here.
Fixes #2656
Signed-off-by: Seppo Ingalsuo seppo.ingalsuo@linux.intel.com