Smart amp tplg fixes #3053
Merged
Smart amp tplg fixes #3053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanderWang
approved these changes
Jun 16, 2020
lgirdwood
requested changes
Jun 16, 2020
plbossart
requested changes
Jun 16, 2020
Member
plbossart
left a comment
There was a problem hiding this comment.
we should not output a 38.4 MCLK, that's way too much.
We should make sure SMART_SSP_QUIRK is set, if it is not defined from the upper layer, let's set it to explicit 0. Signed-off-by: Keyon Jie <[email protected]>
Since we are sharing the same mclk_id among SSP interfaces, we should use the fixed frequency for the mclk. Here add a macro for it to make sure it is aligned with the SSP configure in the upper layer. Change to use 19.2MHz as the default mclk for smart_amp SSP. Signed-off-by: Keyon Jie <[email protected]>
Contributor
Author
|
@lgirdwood @plbossart updated. |
Collaborator
|
Maybe we should use this opportunity to review the mclk value for all existing machines. |
jajanusz
approved these changes
Jun 18, 2020
Contributor
@plbossart @lgirdwood please review this PR, we need it for tgl 0.7 release, thanks |
Contributor
Author
|
@lgirdwood @plbossart ping for comments, this is fix so in urgent. |
lgirdwood
approved these changes
Jun 24, 2020
Member
|
Jenkins CI know issues. |
Member
|
@zrombel looks like CI got stuck, are we good to merge or do you want to rerun ? |
|
Build was re run, and all tests PASS. |
plbossart
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure the SMART_SSP_QUIRK is configured, and use the unify mclk among SSPs.
This will fix thesofproject/linux#2190