test: audio: remove kpb#2598
Merged
jajanusz merged 1 commit intothesofproject:masterfrom Mar 20, 2020
Merged
Conversation
KPB tests don't work and it's better to remove it, than keeping here disabled code. Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Contributor
Author
|
To be clear - there is nothing wrong in removing these files, there were no tests anyway before gcc warn fix was applied today, now we have just tests that are broken, so it's better to clean it up. KPB developer will have to make meaningful UT for it. |
mmaka1
approved these changes
Mar 20, 2020
lbetlej
approved these changes
Mar 20, 2020
Contributor
Author
|
Jenkins known issue, Internal checked with manual test. |
Collaborator
Unless CMocka does something "magical" I don't know about, the gcc warning I fixed in PR #2591 was reporting a probably harmless but real memory corruption. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was previously disabled and someone just turned it, because of GCC warnings, that's why you shouldn't keep unused code, if it doesn't work just remove it and submit working solution.
~
KPB tests don't work and it's better to remove it,
than keeping here disabled code.
Signed-off-by: Janusz Jankowski janusz.jankowski@linux.intel.com