Using a shell redirection instead of sof-logger's -o option#929
Merged
marc-hb merged 1 commit intothesofproject:mainfrom Jul 13, 2022
Merged
Using a shell redirection instead of sof-logger's -o option#929marc-hb merged 1 commit intothesofproject:mainfrom
marc-hb merged 1 commit intothesofproject:mainfrom
Conversation
As sof-logger must run as root, `sudo sof-logger -o ...` creates logs/ directories with a mix of user and root content. Use a plain > redirection instead so all log files are owned by the user running the script. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
Usual suspend/resume failures in https://sof-ci.01.org/softestpr/PR929/build64/devicetest/, everything else green. |
paulstelian97
approved these changes
Jul 12, 2022
paulstelian97
left a comment
There was a problem hiding this comment.
That's what I normally do when manually testing so yea.
This was referenced Jul 19, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As sof-logger must run as root,
sudo sof-logger -o ...creates logs/directories with a mix of user and root content. Use a plain >
redirection instead so all log files are owned by the user running the
script.
Signed-off-by: Marc Herbert marc.herbert@intel.com