hijack.sh: fail if the logger trace is empty#662
Merged
marc-hb merged 1 commit intothesofproject:mainfrom Apr 23, 2021
Merged
Conversation
Does not completely fixes thesofproject#297 but goes a long way. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
The less ambitious #629 passed except on BYT where it fails consistently |
Collaborator
Author
aiChaoSONG
approved these changes
Apr 23, 2021
aiChaoSONG
left a comment
There was a problem hiding this comment.
Note that sof-logger is started by func_lib_start_log_collect in lib.sh, and some cases which only do kernel log check don't call this.
Collaborator
Author
Merging, if BYT (or other?) starts failing this test again then the #663 workaround should help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmit #383 to new
mainbranchDoes not completely fixes #297 but goes a long way.
Signed-off-by: Marc Herbert marc.herbert@intel.com