ASoC: SOF: Intel: hda-ctrl: add missing WAKE_STS clear#4896
ASoC: SOF: Intel: hda-ctrl: add missing WAKE_STS clear#4896plbossart merged 1 commit intothesofproject:topic/sof-devfrom
Conversation
For some reason, the programming sequences in the SOF driver do not include a clear of the WAKE_STS bits before resetting the controller. This clear is not formally required by the HDaudio specification, but was added to harden the snd-hda-reset back in 2007. Adding this sequence back avoids an issue reported by the Intel CI. Closes: thesofproject#4889 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
|
In a comment in #4894 you posted more information and SHA1s which really seem to belong to this commit message:
OK: maybe the last line about your brain is not necessary. |
This was discussed in |
|
I don't want to add more details on this patch. |
|
I wonder why even the purely factual, past SHA1s could confuse reviewers but I imagine they can be found with some well placed |
|
|
||
| /* clear WAKE_STS if not in reset */ | ||
| gctl = snd_sof_dsp_read(sdev, HDA_DSP_HDA_BAR, SOF_HDA_GCTL); | ||
| if (gctl & SOF_HDA_GCTL_RESET) |
There was a problem hiding this comment.
Do we need to test gctl? Can we clear WAKE_STS unconditionally?
There was a problem hiding this comment.
Thanks @plbossart , I got the reason why if (gctl & SOF_HDA_GCTL_RESET) is needed after reading b37a151.
For some reason, the programming sequences in the SOF driver do not include a clear of the WAKE_STS bits before resetting the controller.
This clear is not formally required by the HDaudio specification, but was added to harden the snd-hda-reset back in 2007. Adding this sequence back avoids an issue reported by the Intel CI.
Closes: #4889