[RFC] ASoC: SOF: use 32bit valid sample size for I2S gateway #4016
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1251,7 +1251,7 @@ sof_ipc4_prepare_copier_module(struct snd_sof_widget *swidget, | |
| ipc4_copier = (struct sof_ipc4_copier *)dai->private; | ||
| copier_data = &ipc4_copier->data; | ||
| available_fmt = &ipc4_copier->available_fmt; | ||
| if (dir == SNDRV_PCM_STREAM_CAPTURE || ipc4_copier->dai_type == SOF_DAI_INTEL_SSP) { | ||
|
Member
There was a problem hiding this comment. I am not getting the explanations in the commit message @RanderWang
Author
There was a problem hiding this comment. @plbossart It is true for closed source FW. It depends on ssp blob in case of SOF, so I ask @jsarha for help
Member
There was a problem hiding this comment. Humm, that doesn't sound good at all. This smells of an undocumented dependency between firmware implementation and NHLT blobs. Meh.
Author
There was a problem hiding this comment. yes, different gateway has different requirement and sof should be compatible with closed source fw. |
||
| available_fmt->ref_audio_fmt = available_fmt->out_audio_fmt; | ||
| ref_audio_fmt_size = sizeof(struct sof_ipc4_audio_format); | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message: can we use the same term we are using for the components?
ASoC: SOF: ipc4-topology: Use 32bit sample size for copier on Intel SSPs/FW/The firmware
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should update the comment down at line 1259 as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RanderWang the change looks good but do you have an issue that this PR fixes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and BTW can this be fixed in the nocodec tplg instead?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry missed the issue in the description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ranj063 yong changed nocodec tplg but made no effect thesofproject/sof#6595 (comment).