[RFC] ASoC: SOF: ADL-P uses its own sof_dev_desc#2817
[RFC] ASoC: SOF: ADL-P uses its own sof_dev_desc#2817libinyang wants to merge 1 commit intothesofproject:topic/sof-devfrom
Conversation
Let ADL-P use its own sof_dev_desc for the driver_data. Signed-off-by: Libin Yang <libin.yang@intel.com>
| static const struct sof_dev_desc adlp_desc = { | ||
| .machines = snd_soc_acpi_intel_adl_machines, | ||
| .alt_machines = snd_soc_acpi_intel_adl_sdw_machines, | ||
| .use_acpi_target_states = true, |
There was a problem hiding this comment.
What does .use_acpi_target_states for? Do we need .use_acpi_target_states fir adls_desc, too?
There was a problem hiding this comment.
@bardliao I talked with Keyon 1 week ago for this question. We need to set this flag. And I had a patch to set this flag on some tgl platforms
|
@libinyang wrote:
You could add a note on the firmware name. Something like: "Use a unique filename for ADL-P firmware." |
There was a problem hiding this comment.
I don't object to adding a new descriptor but I object to calling it out with the -p suffix (same for firmware name).
We can consider that ADL-S is different from other skews, and just name the other cases "adl' without listing out the k, h, m, n, y or whatever letters of the alphabet marketing came up with...
|
@libinyang can you look at my PR : #2786 - similar change as yours but different FW name ( as pierre comment above). we can update my PR together too. Let me know your thoughts. |
@sathyap-chrome Sure. I will close this PR. |
|
Uh, sorry @libinyang and @sathyap-chrome -- I had reviewed #2786 earlier... should have made the connection. Let's go with that indeed. |
Let ADL-P use its own sof_dev_desc for the driver_data.
Signed-off-by: Libin Yang libin.yang@intel.com