fixup: ASoC: codec: max98373: return error if tx_mask is set#2202
Merged
plbossart merged 1 commit intothesofproject:topic/sof-devfrom Jun 16, 2020
Merged
fixup: ASoC: codec: max98373: return error if tx_mask is set#2202plbossart merged 1 commit intothesofproject:topic/sof-devfrom
plbossart merged 1 commit intothesofproject:topic/sof-devfrom
Conversation
bardliao
reviewed
Jun 16, 2020
ba7921b to
517438a
Compare
It is instructive for developer. Signed-off-by: Rander Wang <rander.wang@intel.com>
plbossart
approved these changes
Jun 16, 2020
Member
|
@RanderWang the expectation for a fixup is that you use a commit message fixup! Here your commit should have been I fixed this when applying this PR on topic/sof-dev-rebase, but please try to follow the convention next time. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is instructive for developer.
it is a fixup for #2178