Skip to content

ASoC: SOF: increase ipc msg max size #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abonislawski wants to merge 1 commit into from
Closed

ASoC: SOF: increase ipc msg max size #1738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/sound/sof/header.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
#define SOF_IPC_MESSAGE_ID(x) ((x) & 0xffff)

/* maximum message size for mailbox Tx/Rx */
#define SOF_IPC_MSG_MAX_SIZE 384
#define SOF_IPC_MSG_MAX_SIZE 768
Copy link
Collaborator

@lyakh lyakh Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to recall or find where this restriction originally comes from, and I couldn't. @lgirdwood could you remind please? I'll make sure to make a note this time.
I think this restriction comes from the original IPC protocol from the alternative firmware implementation? Currently size limits seem to be set in the firmware by MAILBOX_HOSTBOX_SIZE / MAILBOX_DSPBOX_SIZE macros, for which the smallest value I found was 1024. Is this complete area usable as a mailbox or is a part of it used for other purposes? So, I'd go straight with the largest possible value here. Of course, it has to be reflected in the firmware too.

Copy link
Member Author

@abonislawski abonislawski Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyakh it was discussed on FW PR:
thesofproject/sof#2216
Currently it cannot be set to the largest possible value but it will later with some changes to ipc msg allocations

Copy link
Collaborator

@lyakh lyakh Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abonislawski ok, got it, thanks

Copy link
Member

@plbossart plbossart Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does this work if a new kernel using a max size of 768 is used with an old firmware relying on a value of 384?

And why not 1K while we've at it? or 4K as in the past?


/*
* Structure Header - Header for all IPC structures except command structs.
Expand Down