ASoC: SOF: increase ipc msg max size #1738
Conversation
Increased ipc msg max size will allow to fit a bigger ipc, e.g. needed for mux channel map. Signed-off-by: Adrian Bonislawski <[email protected]>
paulstelian97
left a comment
There was a problem hiding this comment.
Approved as long as it works with the firmware having the corresponding PR merged. There is nothing broken on any of the platforms on the firmware side I assume.
|
|
||
| /* maximum message size for mailbox Tx/Rx */ | ||
| #define SOF_IPC_MSG_MAX_SIZE 384 | ||
| #define SOF_IPC_MSG_MAX_SIZE 768 |
There was a problem hiding this comment.
I tried to recall or find where this restriction originally comes from, and I couldn't. @lgirdwood could you remind please? I'll make sure to make a note this time.
I think this restriction comes from the original IPC protocol from the alternative firmware implementation? Currently size limits seem to be set in the firmware by MAILBOX_HOSTBOX_SIZE / MAILBOX_DSPBOX_SIZE macros, for which the smallest value I found was 1024. Is this complete area usable as a mailbox or is a part of it used for other purposes? So, I'd go straight with the largest possible value here. Of course, it has to be reflected in the firmware too.
There was a problem hiding this comment.
@lyakh it was discussed on FW PR:
thesofproject/sof#2216
Currently it cannot be set to the largest possible value but it will later with some changes to ipc msg allocations
There was a problem hiding this comment.
how does this work if a new kernel using a max size of 768 is used with an old firmware relying on a value of 384?
And why not 1K while we've at it? or 4K as in the past?
plbossart
left a comment
There was a problem hiding this comment.
need more context on ABI and backwards compatibility
|
|
||
| /* maximum message size for mailbox Tx/Rx */ | ||
| #define SOF_IPC_MSG_MAX_SIZE 384 | ||
| #define SOF_IPC_MSG_MAX_SIZE 768 |
There was a problem hiding this comment.
how does this work if a new kernel using a max size of 768 is used with an old firmware relying on a value of 384?
And why not 1K while we've at it? or 4K as in the past?
|
@abonislawski can we close this? it's been shelved since January 21 and bit-rotting since. |
|
@plbossart yes, just a note for everyone: ipc msg size will be send via fw extended manifest |
Ah, good to know, thanks for sharing - makes complete sense to me :-) |
Increased ipc msg max size will allow to fit
a bigger ipc, e.g. needed for mux channel map.
Signed-off-by: Adrian Bonislawski [email protected]