cmoka.h: add new CMOCKA_NORETURN attribute to _fail()#4
Merged
jajanusz merged 1 commit intothesofproject:masterfrom Mar 24, 2020
Merged
cmoka.h: add new CMOCKA_NORETURN attribute to _fail()#4jajanusz merged 1 commit intothesofproject:masterfrom
jajanusz merged 1 commit intothesofproject:masterfrom
Conversation
jajanusz
previously requested changes
Mar 20, 2020
This is a pre-requisite for adding the same ((noreturn)) attribute to test/cmocka/src/common_mocks.c:__panic(), itself required by debug/panic.h:__panic(), itself required to fix a "may be used uninitialized" warning in probe/probe.c, see thesofproject/sof#2581 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
jajanusz
approved these changes
Mar 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pre-requisite for adding the same ((noreturn)) attribute
to test/cmocka/src/common_mocks.c:__panic(), itself required
by debug/panic.h:__panic(), itself required to fix a "may be used
uninitialized" warning in probe/probe.c, see
PR thesofproject/sof#2581
Signed-off-by: Marc Herbert marc.herbert@intel.com