Skip to content

Fix array_combine() on PHP 8.1 #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
silasjoisten merged 1 commit into from
May 13, 2025
Merged

Fix array_combine() on PHP 8.1 #672

silasjoisten merged 1 commit into from
May 13, 2025

Conversation

@cedric-anne
Copy link
Contributor

@cedric-anne cedric-anne commented May 13, 2025

According to the documentation:

As of PHP 8.0.0, a ValueError is thrown if the number of elements in keys and values does not match. Prior to PHP 8.0.0, a E_WARNING was emitted instead.

silasjoisten
silasjoisten approved these changes May 13, 2025
View reviewed changes
Copy link
Collaborator

@silasjoisten silasjoisten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cedric-anne cedric-anne changed the title Fix array_combine() on PHP 8.0 Fix array_combine() on PHP 8.1 May 13, 2025
@silasjoisten silasjoisten merged commit bf4c4c9 into thecodingmachine:master May 13, 2025
10 checks passed
@cedric-anne cedric-anne deleted the fix/array-combine branch May 13, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silasjoisten silasjoisten silasjoisten approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cedric-anne @silasjoisten