BG2-3023: Publish PHP 8.5 docker images #23
+66
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c69b48e to
b38b131
Compare
bdsl
commented
Feb 12, 2026
| # for e.g. CI test coverage. This means we can use the normal `8.5` tag for Production without | ||
| # incurring significant extra overhead. | ||
| RUN pecl install xdebug | ||
| RUN docker-php-ext-enable xdebug |
Contributor
Author
There was a problem hiding this comment.
copied from existing 8.3 file, just replaced 3 with 5.
bdsl
commented
Feb 12, 2026
Contributor
Author
There was a problem hiding this comment.
copied from existing 8.3 file, just replaced 3 with 5 and bullseye with bookworm
NoelLH
reviewed
Feb 12, 2026
Contributor
NoelLH
left a comment
There was a problem hiding this comment.
Apart from reviewing the old Composer pin, LGTM
Comment on lines
+17
to
+23
| # Pin to 2.4.1 for now because 2.4.2 introduced a permissions regression (or tightening) that | ||
| # doesn't work with our built-as-root(?) images, without per-app changes everywhere that | ||
| # Composer is used (e.g. multiple times in every entrypoint). This temporary pin seems like a | ||
| # reasonable step for now because it sounds like Composer are open to improving the behaviour | ||
| # here and there is active discussion this week (23/9/22). | ||
| # https://github.com/composer/composer/issues/11073 | ||
| RUN curl -sS https://getcomposer.org/installer | php -- --version=2.4.1 --install-dir=/usr/local/bin --filename=composer |
Contributor
There was a problem hiding this comment.
Can we try a newer Composer now? Looks like Docker detection was improved in 2024 from composer/composer#11073
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.