Bump kcd-scripts to 12.x#1208
Merged
eps1lon merged 3 commits intotesting-library:alphafrom Jan 29, 2023
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7efa04d:
|
Codecov Report
@@ Coverage Diff @@
## alpha #1208 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 998 998
Branches 327 327
=========================================
Hits 998 998
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
5049ce9 to
e5efaa8
Compare
eps1lon
commented
Jan 29, 2023
| expect(console.error.mock.calls[0][0]).toMatch( | ||
| 'Error: Not implemented: window.computedStyle(elt, pseudoElt)', | ||
| expect(console.error.mock.calls[0][0].message).toMatch( | ||
| 'Not implemented: window.computedStyle(elt, pseudoElt)', |
Member
Author
There was a problem hiding this comment.
JSDOM now calls console.error with the actual Error instance instead of its stringified version
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Bump kcd-scripts to 12.x
Why:
Get newer versions of JSDOM
How:
Bump kcd-scripts to 12.x
Checklist:
docs site