Allow testcontainer to wait for a specific port#703
Merged
Conversation
*Motivation* A container might expose multiple ports for different purposes. for example, it can have a port for http endpoint, while having another port for grpc endpoint. So when doing a liveness check, it would be better to allow configuring checking a specific port, rather than checking the first exposed port. *Modification* Modify the `HttpWaitStrategy` to allow configuring the liveness port.
bsideup
requested changes
May 18, 2018
Member
bsideup
left a comment
There was a problem hiding this comment.
Nice one, thanks!
Just a minor comment about the log level
Also, could you please add it to CHANGELOG.md?
| connection.setRequestMethod("GET"); | ||
| connection.connect(); | ||
|
|
||
| log.info("Get response code {}", connection.getResponseCode()); |
Member
There was a problem hiding this comment.
I would change this (and Get response {}) to .debug or even .trace
Contributor
Author
There was a problem hiding this comment.
@bsideup thank you for review.
I changed the logging from INFO to TRACE and added an item to changelog.md.
Let me know if that looks better now :)
- add an item in CHANGELOG.md
bsideup
approved these changes
May 18, 2018
Member
|
@sijie merged, thanks! 👍 |
Contributor
Author
|
thank you @bsideup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A container might expose multiple ports for different purposes. for example, it can have a port for http endpoint,
while having another port for grpc endpoint. So when doing a liveness check, it would be better to allow configuring
checking a specific port, rather than checking the first exposed port.
Modification
Modify the
HttpWaitStrategyto allow configuring the liveness port.