Skip to content

Add jdk9 build to travis#562

Merged
rnorth merged 6 commits into
masterfrom
travis-jdk9
Jan 28, 2018
Merged

Add jdk9 build to travis#562
rnorth merged 6 commits into
masterfrom
travis-jdk9

Conversation

@kiview
Copy link
Copy Markdown
Member

@kiview kiview commented Jan 28, 2018

I've added a jdk9 build (basically the first compiling step) to Travis. I also wonder if we should add openjdk8 and openjdk9 to the compiling step, or maybe switch to openjdk from oraclejdk, but it might be not really important for us,

Comment thread .travis.yml Outdated
language: java
jdk:
- oraclejdk8
- oraclejdk9
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will double the required number of executors on Travis:(

I would rather add 1 stage like docker-in-alpine-docker but with openjdk:9-jdk-alpine

Copy link
Copy Markdown
Member Author

@kiview kiview Jan 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK this does not double the required number of executors, since it seems it's not applied as a matrix configuration in this case, but will only duplicate the

install:
  - echo "MAVEN_OPTS='-XX:+TieredCompilation -XX:TieredStopAtLevel=1'" > ~/.mavenrc
  - ./mvnw -T4 -DskipTests=true -Dmaven.javadoc.skip=true install

step and not the individual jobs. At least it looks like this in Travis.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also wonder why this step runs tests on case of jdk9?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, travis seems to have added a new default job for both JDKs instead of applying it to the build matrix, I'll try something else instead.

@kiview
Copy link
Copy Markdown
Member Author

kiview commented Jan 28, 2018

Btw. it seems like some Docker-Compose tests are failing with JDK9 🙀

@kiview
Copy link
Copy Markdown
Member Author

kiview commented Jan 28, 2018

Also ensured JDK9 compatibility by adding explicit dependency on javax.xml.bind.jaxb-api.

@rnorth
Copy link
Copy Markdown
Member

rnorth commented Jan 28, 2018

LGTM

@bsideup bsideup added this to the 1.6.0 milestone Jan 28, 2018
@rnorth rnorth merged commit 1cbfec6 into master Jan 28, 2018
@rnorth rnorth deleted the travis-jdk9 branch January 28, 2018 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants