Adding fluent builder withLink for addLink method#463
Conversation
|
AFAIK, linking is discouraged and using Docker networking should be preferred after all. |
|
Indeed, Docker recommends to avoid usage of legacy link functionality unless absolutely necessary. Then I believe there are two logical alternatives: either |
|
Networking in Testcontainers should be stable enough to deprecate |
|
@kiview sounds good :) Networks are stable, less error-prone and easier to use :) |
|
@rnorth are you fine with it as well? Is |
|
I'm fine with deprecating use of links; this predates the existence of network support in Docker, and I'd agree that we've waited long enough. There are a few things I'd like to do in the process of deprecating - I'll raise an issue for further tracking/discussion. @orange-buffalo thank you for raising the PR, but would you be OK with closing based on the above? |
|
@rnorth, sure, I will close the PR. |
It would be very convenient to add links to another containers using fluent builder. Currently
addLinkmethod has no fluent alternative. This PR introduces one:withLink.