Fix invalid connection URLs returned by PostgreSQLContainer (#1976) #2049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
requested changes
Nov 8, 2019
modules/postgresql/src/test/java/org/testcontainers/containers/PostgreSQLConnectionURLTest.java
Show resolved
Hide resolved
bsideup
requested changes
Jan 27, 2020
modules/postgresql/src/main/java/org/testcontainers/containers/PostgreSQLContainer.java
Outdated
Show resolved
Hide resolved
modules/postgresql/src/test/java/org/testcontainers/containers/PostgreSQLConnectionURLTest.java
Show resolved
Hide resolved
modules/postgresql/src/main/java/org/testcontainers/containers/PostgreSQLContainer.java
Outdated
Show resolved
Hide resolved
bsideup
requested changes
Jan 27, 2020
modules/postgresql/src/main/java/org/testcontainers/containers/PostgreSQLContainer.java
Show resolved
Hide resolved
bsideup
reviewed
Jan 27, 2020
modules/postgresql/src/main/java/org/testcontainers/containers/PostgreSQLContainer.java
Show resolved
Hide resolved
bsideup
approved these changes
Mar 10, 2020
Member
|
@pivovarit merged 🎉 thank you! |
Member
|
This was released in https://github.com/testcontainers/testcontainers-java/releases/tag/1.14.0 🎉 Thanks for the contribution! |
rnorth
added a commit
that referenced
this pull request
May 22, 2020
quincy
pushed a commit
to quincy/testcontainers-java
that referenced
this pull request
May 28, 2020
…stcontainers#1976) (testcontainers#2049) * Reproduce testcontainers#1976 in tests * Override constructUrlForConnection for PostgreSQLContainer * Lighten PostgreSQLConnectionURLTest * Lighten PostgreSQLConnectionURLTest * Cater for base URLs without query strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduced the bug: 8803fe1
Fix #1976 by overriding
PostgreSQLContainer#constructUrlForConnectionNeeded to cater for an empty
Stringcase regardless of the fact that it breaks the method contract:because:
testcontainers-java/modules/jdbc/src/main/java/org/testcontainers/containers/JdbcDatabaseContainer.java
Line 129 in f1565f1