Support MySQL 8#1470
Merged
Merged
Conversation
rnorth
commented
May 15, 2019
| rs.next(); | ||
| String resultSetInt = rs.getString(2); | ||
| assertEquals("Passing query parameters to set DB connection encoding is successful", "utf8", resultSetInt); | ||
| assertEquals("Passing query parameters to set DB connection encoding is successful", "utf8mb4", resultSetInt); |
Member
Author
There was a problem hiding this comment.
This is to match the changes mentioned here
For Connector/J 8.0.13 and later:
When UTF-8 is used for characterEncoding in the connection string, it maps to the MySQL character set name utf8mb4.
rnorth
commented
May 15, 2019
| url = url + separator + "useSSL=false"; | ||
| } | ||
|
|
||
| if (! url.contains("allowPublicKeyRetrieval=")) { |
Member
Author
There was a problem hiding this comment.
This is the main substance of this change.
kiview
approved these changes
May 27, 2019
Member
kiview
left a comment
There was a problem hiding this comment.
LGTM, thanks for extracting AbstractContainerDatabaseTest class also.
Member
Author
|
Thanks @kiview - will merge! |
|
When will you publish a release with this? |
Member
Author
|
This was released in 1.11.4 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #736
Replaces #1168
Note that this PR includes some long overdue refactoring of the database container tests - it made sense to do this as I was adding another test class, and doing so without refactoring would have worsened duplication.
The actual substance of the change is quite small, and visible in the MySQLContainer class.
Quoting the rationale: