Fix abort handling for notes with multiple D2 blocks#58
Open
RacyMind wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbortErrors as superseded renders instead of D2 compilation failures.Why
Obsidian runs the markdown code block processor once for each fenced D2 block, but the plugin currently stores
debouncedMapandabortControllerMapentries under a page-level ID. In notes with more than one D2 block, a later block can abort an in-flight render for an earlier block on the same page. That aborted child process surfaces asAbortError: The operation was aborted, which the plugin currently renders asD2 Compilation Erroreven though D2 did not fail to compile the diagram.This also fixes the cleanup mismatch where controllers are stored under
pageIDbut deleted usingpageContainer.dataset.id.Validation
node_modules\.bin\tsc.cmd -noEmit -skipLibChecknode esbuild.config.mjs productionnode --check main.js