fix: install wrapper after version/cache steps #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract version detection into getInstalledVersion function - Move wrapper installation after version detection and caching - Ensures version output is captured before wrapper intercepts stdout - Prevents caching wrapped binary, which caused issues on cache hits - Add test to verify tflint-version output with wrapper enabled Fixes #356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
tflint_wrapper: trueis enabled, the wrapper was being installed before version detection and caching. This caused the wrapper to capture TFLint's stdout, preventing the setup action from parsing and outputting the version. It also meant the wrapped binary was cached instead of the real binary, causing failures on subsequent cache hits.Issue
The wrapper script intercepts TFLint execution and captures stdout/stderr. When installed before version detection, running
tflint --versionproduced no output for the setup script to parse, triggering the warning "Unable to parse tflint version from output."Additionally, the wrapper was installed before caching, so the cache contained the wrapped binary. On cache hits, the version detection would fail because it was calling the wrapper without the real binary (
tflint-bin) present.Changes
getInstalledVersionfunctionintegration-wrapperworkflow to verifytflint-versionoutput is capturedTesting
tflint-versionoutput with wrapper enabledactfor both fresh installs and cached scenariosReferences
Closes #356