Skip to content

Marks template.volumes.secret.items.mode field not required in Cloud Run V2 resources#509

Merged
modular-magician merged 1 commit into
terraform-google-modules:masterfrom
modular-magician:downstream-pr-9938233d01b90e87558fabb2f97b7d42d7896127
Aug 25, 2023
Merged

Marks template.volumes.secret.items.mode field not required in Cloud Run V2 resources#509
modular-magician merged 1 commit into
terraform-google-modules:masterfrom
modular-magician:downstream-pr-9938233d01b90e87558fabb2f97b7d42d7896127

Conversation

@modular-magician

Copy link
Copy Markdown
Collaborator

I think this field was marked as required initially by mistake. Our API doesn't require this field and doesn't set a service side default value.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudrunv2: Changed `template.volumes.secret.items.mode` field in `google_cloud_run_v2_job` resource to a non-required field.
cloudrunv2: Changed `template.volumes.secret.items.mode` field in `google_cloud_run_v2_service` resource to a non-required field.

Derived from GoogleCloudPlatform/magic-modules#8771

…d Run V2 resources (#8771)

* removed require

* remove required for job

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 7787553 into terraform-google-modules:master Aug 25, 2023
@modular-magician modular-magician deleted the downstream-pr-9938233d01b90e87558fabb2f97b7d42d7896127 branch November 18, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant