Include Page Title for InputfieldPage fields#2
Conversation
Owner
|
@schefflerinc, thanks for this! I started by testing your changes, but ended up implementing something a bit more complex; you can see the result in commit 9ca89a6. This commit adds a new way to both calculate and display changes for page fields. I hope that works for you too. |
Author
|
Looks good. Thanks a lot :) |
mn-martin
pushed a commit
to mn-martin/VersionControl
that referenced
this pull request
Sep 22, 2016
Your Selector is not compatible with: sql_mode=only_full_group_by Errors: SQLSTATE[42000]: Syntax error or access violation: 1055 Expression teppokoivula#7 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'objektdatenbank.d.property' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by (in /site/modules/VersionControl/ProcessVersionControl.module line 249) SQLSTATE[42000]: Syntax error or access violation: 1055 Expression teppokoivula#8 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'objektdatenbank.d.data' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by (in /site/modules/VersionControl/ProcessVersionControl.module line 248) SQLSTATE[42000]: Syntax error or access violation: 1055 Expression teppokoivula#2 of ORDER BY clause is not in GROUP BY clause and contains nonaggregated column 'objektdatenbank.d.id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by (in /site/modules/VersionControl/ProcessVersionControl.module line 249)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the diff view to include page titles for InputfieldPage fields to allow editors to easily see what has been changed.
Uses
labelFieldNameandlabelFieldFormatto keep the output consistent with the values shown for the normal field