Fixing the native build so it can find the TSL headers #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karllessard
reviewed
Apr 3, 2024
| // The lower part is still the same, so multiple roots are set in the pom file. | ||
| "tsl/platform/ctstring_internal.h", | ||
| "tsl/platform/ctstring.h", | ||
| "tsl/c/tsl_status.h", |
Collaborator
There was a problem hiding this comment.
I don't see a root in the pom file that has the tensorflow/ suffix, to replace the existing paths, is this still required?
karllessard
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TSL headers are in a different source root in a Bazel build to the packaged whl files. This PR adds that source root to the JavaCPP generate task and modifies the preset to look for them in both places.
Fixes #529.
It also pulls in the start of some changes I was making to reduce the number of warnings from error prone, but I've not completed that yet.