fix(sdk): no longer error on cancelling fired timer#1268
Merged
Conversation
Sushisource
approved these changes
May 14, 2026
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Update cancelling a timer to no longer require a matching timer which can happen if the timer was already fired.
Why?
We now match other SDKs where cancelling a fired timer is a no-op.
Checklist
Addresses timer issue reported in [Bug] Per-task failures escape existing isolation and become worker-fatal (0.4.0) #1254
How was this tested:
Added integration test to verify we no longer fail on canceling a future that has fired.
Any docs updates needed?
N/A