build: make otel opt-in in sdk-core#1154
Merged
chris-olszewski merged 4 commits intoMar 18, 2026
Merged
Conversation
Disable sdk-core's default otel feature and wire otel explicitly where needed to reduce transitive dependencies for non-otel consumers.
chris-olszewski
requested changes
Mar 16, 2026
chris-olszewski
left a comment
Member
There was a problem hiding this comment.
Overall looks good, just 2 things to get it in working order.
Comment on lines
+18
to
+19
| # OpenTelemetry metrics export via OTLP. Disabled by default to reduce build times and | ||
| # dependency count for users who use Prometheus or custom meters only. |
Member
There was a problem hiding this comment.
I don't feel the comment is especially useful
Suggested change
| # OpenTelemetry metrics export via OTLP. Disabled by default to reduce build times and | |
| # dependency count for users who use Prometheus or custom meters only. |
Contributor
Author
There was a problem hiding this comment.
Sure Will Implement the suggested changes
Comment on lines
+15
to
+16
| "--features", | ||
| "temporalio-sdk-core/otel", |
Member
There was a problem hiding this comment.
We need to mirror this change in crates/sdk-core/tests/runner.rs
Contributor
Author
There was a problem hiding this comment.
I have added the changes in the file
Remove the nonessential feature comment and mirror the otel feature in the integration test runner so it matches the cargo alias behavior.
chris-olszewski
approved these changes
Mar 18, 2026
This was referenced Apr 3, 2026
Closed
This was referenced May 1, 2026
Closed
This was referenced May 15, 2026
Closed
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable sdk-core's default otel feature and wire otel explicitly where needed to reduce transitive dependencies for non-otel consumers.