Add plugin to workflowenvironment#1015
Merged
tconley1428 merged 3 commits intomainfrom Aug 5, 2025
Merged
Conversation
Contributor
|
Is there a way to get some coverage for this by using it in our own tests? E.g. somehow cleaning up this pattern? async def test_some_test(client: Client):
new_config = client.config()
new_config["plugins"] = [
openai_agents.OpenAIAgentsPlugin(
model_params=ModelActivityParameters(
start_to_close_timeout=timedelta(seconds=30)
),
model_provider=CustomModelProvider(),
)
]
client = Client(**new_config) |
Quinn-With-Two-Ns
approved these changes
Jul 31, 2025
Contributor
Author
Potentially. I might have to understand more about pytest fixtures though, and it might be more difficult to see what is actually being validated. The same could theoretically be said for any other client modifications we do. |
tconley1428
added a commit
that referenced
this pull request
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Came up as a question in #1009
Checklist
Closes
How was this tested: